Use `mkdir -p` instead of ignoring return code #675

rhansen · 2024-02-28T08:16:35Z

(split off from #642 because I suspect this change is less controversial)

The `-f` option causes `rm` to silently ignore files that don't exist, so `rm -rf` will only fail if `rm` has trouble deleting a file that exists. We want `make` to fail in that situation.

We want `make` to fail if the directory doesn't exist and can't be made for some reason.

rhansen force-pushed the make branch from 3d324bc to 9fe306e Compare March 8, 2024 09:13

rhansen force-pushed the make branch from 9fe306e to c40ce16 Compare May 17, 2024 06:03

rhansen force-pushed the make branch from c40ce16 to 210a0e2 Compare July 10, 2024 06:44

rhansen added 2 commits September 8, 2024 22:23

Don't ignore the return value from rm -rf

1dab7b2

The `-f` option causes `rm` to silently ignore files that don't exist, so `rm -rf` will only fail if `rm` has trouble deleting a file that exists. We want `make` to fail in that situation.

Use mkdir -p instead of ignoring return code

33c38a7

We want `make` to fail if the directory doesn't exist and can't be made for some reason.

rhansen force-pushed the make branch from 210a0e2 to 33c38a7 Compare September 9, 2024 02:44

rhansen mentioned this pull request Sep 10, 2024

Use autotools (autoconf, automake) to build keyd #831

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `mkdir -p` instead of ignoring return code #675

Use `mkdir -p` instead of ignoring return code #675

rhansen commented Feb 28, 2024

Use mkdir -p instead of ignoring return code #675

Are you sure you want to change the base?

Use mkdir -p instead of ignoring return code #675

Conversation

rhansen commented Feb 28, 2024

Use `mkdir -p` instead of ignoring return code #675

Use `mkdir -p` instead of ignoring return code #675